Don't look up TargetId in notifyLocalViewChanges #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
approved these changes
Jul 30, 2018
| return PersistencePromise.waitFor(promises); | ||
| }); | ||
| notifyLocalViewChanges(viewChanges: LocalViewChanges[]): void { | ||
| for (const view of viewChanges) { |
There was a problem hiding this comment.
Since you've rewritten most of this loop, maybe go ahead and rename 'view' to 'viewChange' for sanity?
| @@ -26,11 +27,15 @@ import { documentKeySet, DocumentKeySet } from '../model/collections'; | |||
| export class LocalViewChanges { | |||
| constructor( | |||
| readonly query: Query, | |||
There was a problem hiding this comment.
I think query is unused now. Remove it?
There was a problem hiding this comment.
Yup, done.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a QueryData read from
notifyLocalViewChanges. This read happened for every target update and was merely used to look up the target ID.