Attempt to delete client metadata row #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
approved these changes
Aug 16, 2018
| this.removeItem(this.localClientStorageKey); | ||
| this.started = false; | ||
| if (this.started) { | ||
| this.platform.window.removeEventListener('storage', this.storageListener); |
There was a problem hiding this comment.
Should we remove the 'unload' hook too? (FWIW that might mean we don't need the this.started check, though I don't know if that's guaranteed or not... so probably fine to leave it.)
There was a problem hiding this comment.
I'm tempted not to. It provides very little gain and adds more state keeping (I would have to keep a reference to the original function pointer for it to work consistently in all browsers).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should try to delete the client metadata row from LocalStorage even if
.shutdown()wasn't called. Because it won't be.