Various auth fixes #1141
Merged
Various auth fixes #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bojeil-google
commented
Aug 19, 2018
bojeil-google
commented
- Fixes exportPrototypeProperties for multiple properties where the last property overrides the previous properties.
- Fixes fireauth.messagechannel.Sender.
- Fixes service worker indexedDB on some slow browsers, which was detected in Edge.
…t property overrides the previous properties.
Currently, this does not allow sending multiple messages from the same sender, since the port can only be transferred one time. The implementation has been modified to open a new messagechannel on each message instead. Note this does not affect indexeddb usage of this utility since a new sender is created each time and one message sent.
…ted in Edge. Unfortunately, some browsers (detected in Edge) are too slow to detect the first ack event and timeout quickly. Instead what we can do is assume the following: 1. one service worker activated at one time. 2. The service worker once subscribed to the keyChanged event will not unsubscribe. So on initialization, the client will ping the service worker when it's ready to get all subscribed events with a long timeout. If the service worker responds with the keyChanged event, we can deduce that the sw can handle this event. The next time a change event occurs, we can safely use a long ACK timeout.
wti806
approved these changes
Aug 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.