Speed up FieldPath validation tests #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var-const
approved these changes
Aug 20, 2018
| promises.push(expectFieldPathToFail(db, fieldPath, reason)); | ||
| } | ||
| return Promise.all(promises); | ||
| const docRef = db.collection('test').doc(); |
There was a problem hiding this comment.
Optional nit: consider refactoring the piece of code that promises a snapshot into a helper function. OTOH, since it's only repeated twice, it might not be worth it.
There was a problem hiding this comment.
You had me at "optional". I'll leave it as is for now.
|
Adding @wilhuff for Owners. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two test cases that keep failing for me on CI, and I hope that I can make them pass more often by moving some of the document mutations out of the for-loop and into the initialization.