Make MaybeDocument an abstract class #1153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt-maybedocument
branch
from
b403624 to
bc60dd7
Compare
wilhuff
reviewed
Aug 21, 2018
| * Represents a document in Firestore with a key, version, data and whether the | ||
| * data has local mutations applied to it. | ||
| */ | ||
| export class Document implements MaybeDocument { |
There was a problem hiding this comment.
Shouldn't this be extends rather than implements?
Here and below.
There was a problem hiding this comment.
Yeah, I would have hoped that TS complains about things like this.
| @@ -68,7 +81,7 @@ export class Document { | |||
| ); | |||
| } | |||
|
|
|||
| static compareByKey(d1: MaybeDocument, d2: MaybeDocument): number { | |||
| static compareByKey(d1: Document, d2: Document): number { | |||
There was a problem hiding this comment.
Why shouldn't this accept MaybeDocument?
There was a problem hiding this comment.
I moved this method up to the base class and changed it to accept MaybeDocument. I just thought it was odd that it accepts MaybeDocument, but is part of a subclass.
|
CI failed to build on this error: TS2345 Argument of type 'MaybeDocument' is not assignable to parameter of type 'Document'.\n Property 'hasLocalMutations' is missing in type 'MaybeDocument' |
|
Feedback addressed. Build passing :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... with the class comments from Android.