Skip to content

Comment cleanup #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Comment cleanup #1196

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
276c77f
Rename UnknownDocument.readTime to version
schmidt-sebastian Sep 4, 2018
af15e0c
Updating outdated comment
schmidt-sebastian Sep 5, 2018
cf2de39
Merge branch 'mrschmidt-commitversion' into mrschmidt-rename
schmidt-sebastian Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/firestore/src/model/mutation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,8 +234,9 @@ export abstract class Mutation {
* @param maybeDoc The document to mutate. The input document can be null if
* the client has no knowledge of the pre-mutation state of the document.
* @param mutationResult The result of applying the mutation from the backend.
* @return The mutated document. The returned document may be null, but only
* if maybeDoc was null and the mutation would not create a new document.
* @return The mutated document. The returned document may be an
* UnknownDocument if the mutation could not be applied to the locally
* cached base document.
*/
abstract applyToRemoteDocument(
maybeDoc: MaybeDocument | null,
Expand Down