Skip to content

Functions test fix #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2018
Merged

Functions test fix #1236

merged 2 commits into from
Sep 19, 2018

Conversation

Feiyang1
Copy link
Member

check browser compatibility more reliably before running the test

Copy link
Contributor

@bklimt bklimt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Feiyang1 Feiyang1 merged commit a4ab0f6 into master Sep 19, 2018
@Feiyang1 Feiyang1 deleted the functions-test-fix branch September 19, 2018 19:08
@firebase firebase locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants