Skip to content

TypeScript support for useFunctionsEmulator #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

ifiokjr
Copy link
Contributor

@ifiokjr ifiokjr commented Sep 29, 2018

According to this comment this is now supported in the library.

This tiny PR makes it available for TypeScript users without d.ts hacks.

According to this [comment](firebase#941 (comment)) this is now supported in the library. I just couldn't see it anywhere in the types.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ifiokjr
Copy link
Contributor Author

ifiokjr commented Sep 30, 2018

I've signed it.

@googlebot
Copy link

CLAs look good, thanks!

@Feiyang1
Copy link
Member

Awesome! LGTM, thanks for the contribution!

@Feiyang1 Feiyang1 merged commit de179c9 into firebase:master Oct 30, 2018
@firebase firebase locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants