Remove Symbol.iterator #1330
Merged
Remove Symbol.iterator #1330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
gsoltis,
mikelehen,
rsgowman,
var-const,
wilhuff and
zxu123
as code owners
mikelehen
suggested changes
Oct 23, 2018
| // tslint:disable-next-line:no-any Accept any kind of `forEach`. | ||
| collection: { forEach: ((cb: ((k: K, ...args: any[]) => void)) => void) }, | ||
| // tslint:disable-next-line:no-any Accept any kind of callback. | ||
| f: (k: K, ...args: any[]) => PersistencePromise<void> |
There was a problem hiding this comment.
Uh... these type gymnastics are pretty crazy. Seems like there has to be a better way?
Maybe just define our own Iterable type (with a normal method instead of Symbol.iterator)?
FWIW I wouldn't be surprised if doing ...args in an inner loop is a mildly bad practice for performance reasons. Though I'd have to look at the generated code to be sure.
There was a problem hiding this comment.
I changed the type a bit to remove the varargs. This gets us saner types and a bit more type safety (see the related changes in the last commit).
The generated code uses apply().
schmidt-sebastian
force-pushed
the
mrschmidt-foreachable
branch
from
50065eb to
ef455a7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows use of Firestore in IE11 without Polyfills.
Fixes #1308