Skip to content

Create empty-import.d.ts and reference it in submodule imports #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2019

Conversation

ifiokjr
Copy link
Contributor

@ifiokjr ifiokjr commented Oct 30, 2018

A full reproduction of the error is available below

https://github.com/davideast/rxfire-samples/blob/f4b0b6b7959b7fb52b04fb7a8041edb17b92a872/src/preact/index.tsx#L20-L23

// NOTE: The lazy load for Firestore does not work with TypeScipt
// w/out hacking the node_modules/firebase/firestore/package.json file
// to use "typings": "../index.d.ts".
const firestore$ = from(import('firebase/firestore'));

@Feiyang1
Copy link
Member

Feiyang1 commented Nov 2, 2018

Awesome, LGTM. Thank you very much. Can you please close this one and create a new PR on top of the HEAD? We had a hiccup in CI build, so the build fails for this PR.

@ifiokjr
Copy link
Contributor Author

ifiokjr commented Nov 3, 2018

@Feiyang1 I've just rebased from the latest master.

Also I've added another typings fix for rxfire/database. Currently it's not being referenced in the package.json.

Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifiokjr
Copy link
Contributor Author

ifiokjr commented Nov 23, 2018

@Feiyang1 thanks for approving! 👍
@davideast Any chance this could be merged soon. It'll save me from the ugly post-install bash script I'm currently using to bypass the issue.

@Feiyang1 Feiyang1 merged commit d96a806 into firebase:master Jan 9, 2019
ifiokjr added a commit to ifiokjr/firebase-js-sdk that referenced this pull request Jan 19, 2019
Feiyang1 pushed a commit that referenced this pull request Jan 25, 2019
@firebase firebase locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typings not being told in package.json
4 participants