Skip to content

Upgrade GRPC to 1.16.0 #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2018
Merged

Upgrade GRPC to 1.16.0 #1353

merged 2 commits into from
Nov 6, 2018

Conversation

squirly
Copy link
Contributor

@squirly squirly commented Nov 2, 2018

This removes a deprecated call used internally by GRPC, fixing the deprecation warning.

Fixes #1113

@mikelehen
Copy link
Contributor

Thanks! Do you mind upgrading packages/testing/package.json as well, so the whole SDK is on the same version?

@mikelehen
Copy link
Contributor

Did you regenerate yarn.lock after upgrading packages/testing ? I expected to see 1.13.1 disappear.

@squirly
Copy link
Contributor Author

squirly commented Nov 5, 2018

@mikelehen Updated!

Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mikelehen mikelehen merged commit a6aa999 into firebase:master Nov 6, 2018
@Djiit
Copy link

Djiit commented Nov 6, 2018

Hi folks, thanks for that !

@squirly squirly deleted the upgrade-grpc branch November 6, 2018 16:30
@firebase firebase locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc deprecated error sdk 5.3.1
6 participants