Upgrade mocha version to 5.2.0 in all packages. #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are trying to consolidate flags passed to mocha test into mocha.opts (a mocha config file). In order for mocha to support comments in this file, mocha needs to be upgraded to its latest version (5.2.0 as of 11/09/2018).
yifanyang
requested review from
davideast,
depoll,
dwoffinden,
gauntface,
gsoltis,
hiranya911,
mikelehen,
mmermerkaya,
pinarx,
rsgowman,
ryanpbrewster,
schmidt-sebastian,
tonymeng,
var-const,
wilhuff and
zxu123
as code owners
ryanpbrewster
approved these changes
Nov 9, 2018
Feiyang1
approved these changes
Nov 9, 2018
tonymeng
approved these changes
Nov 9, 2018
mmermerkaya
approved these changes
Nov 10, 2018
|
ping ... |
mikelehen
approved these changes
Nov 20, 2018
There was a problem hiding this comment.
LGTM. FWIW, we (Firestore at least) don't look at reviews unless they're assigned to us (because our github OWNERS setup auto-adds everybody as reviewers, so it's not clear who actually needs to take action)
So if you're waiting for somebody, I suggest adding them to assignees!
|
@mikelehen Thanks for the tips! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to consolidate flags passed to mocha test into mocha.opts. In order to support comments in this file, mocha needs to be upgraded to its latest version (5.2.0 as of 11/09/2018).
See discussion in #1373 for more context.