Skip to content

Limit gRPC's built-in exponential backoff #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 20, 2018
Merged

Limit gRPC's built-in exponential backoff #1390

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b891dd
Prevent gRPC from performing too much exponential backoff
ryanpbrewster Nov 20, 2018
6dc99fa
[AUTOMATED]: Prettier Code Styling
ryanpbrewster Nov 20, 2018
5e49a1c
Simplify comment
ryanpbrewster Nov 20, 2018
cea5146
Set the initial backoff as low as possible
ryanpbrewster Nov 20, 2018
8da0425
revert testing change
ryanpbrewster Nov 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/firestore/src/platform_node/grpc_connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,17 @@ export class GrpcConnection implements Connection {
? grpc.credentials.createSsl()
: grpc.credentials.createInsecure();
this.cachedStub = {
stub: new this.firestore.Firestore(this.databaseInfo.host, credentials),
stub: new this.firestore.Firestore(
this.databaseInfo.host,
credentials,
{
// We do our own connection backoff (that for example is aware of whether or
// not a write stream error is permanent or not) so we don't want gRPC to do
// backoff on top of that. 100ms is the minimum value that gRPC allows.
'grpc.initial_reconnect_backoff_ms': 100,
'grpc.max_reconnect_backoff_ms': 100
}
),
token
};
}
Expand Down