Skip to content

Remove "can write very large batches" test. #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

mikelehen
Copy link
Contributor

This reverts commit 20beaef.

This test takes ~6s to run causing some timeouts, and it is unlikely to regress
given IndexedDb doesn't have inherent size limitations for us to work around.

This reverts the test added in commit 20beaef
but leaves the test re-ordering.

The test took ~6s to run causing some timeouts, and we're unlikely to regress
large batch support given IndexedDb doesn't have inherent size limitations for
us to work around.
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned mikelehen and unassigned wilhuff Jan 31, 2019
@mikelehen mikelehen merged commit d0f981e into master Feb 1, 2019
@mikelehen mikelehen deleted the mikelehen/remove-slow-batch-test branch February 1, 2019 00:31
@firebase firebase locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants