Skip to content

Fix lint: Two NOs make a YES #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2019
Merged

Fix lint: Two NOs make a YES #1652

merged 1 commit into from
Apr 2, 2019

Conversation

abhijeethp
Copy link
Contributor

Fix lint: Two NOs make a YES 😄

@abhijeethp
Fix lint
b6dc1cb 
two NOs make a YES 😄
mikelehen
mikelehen approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution! 😄

@mikelehen mikelehen merged commit 46e3280 into firebase:master Apr 2, 2019
@firebase firebase locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

@jsdt jsdt Awaiting requested review from jsdt

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhijeethp @mikelehen