Add "experimentalForceLongPolling" option. #1662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
mikelehen
force-pushed
the
mikelehen/force-long-polling
branch
from
9ce9665 to
1e38673
Compare
wilhuff
approved these changes
Apr 8, 2019
packages/firebase/index.d.ts
Outdated
| * buffer traffic indefinitely. Use of this option will cause some | ||
| * performance degradation though. | ||
| * | ||
| * This setting may be removed in a future release. |
There was a problem hiding this comment.
Should we invite users to discuss with us when they're using this?
The backend will have logs of when this is actually used, but if the rest of the world starts using this by default we won't know why otherwise.
packages/firestore/CHANGELOG.md
Outdated
| @@ -1,4 +1,6 @@ | |||
| # Unreleased | |||
| - [feature] Added an `experimentalForceLongPolling` setting that may be helpful | |||
There was a problem hiding this comment.
Could we make the call to action more concrete here?
Maybe "... setting that can be used to work around proxies that prevent the Firestore client from connecting to its backend"?
|
@hsubox76 Can you approve for the .d.ts updates? FWIW- This option is actually only applicable to web, and so if there's a way to hide it from the node docs, let me know. Else, it's not a big deal (you can actually set the option from node, it'll just be a no-op). |
hsubox76
reviewed
Apr 9, 2019
hsubox76
approved these changes
Apr 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.