Skip to content

Validate operator enum in Query.where() calls #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 9, 2019
Merged

Validate operator enum in Query.where() calls #1677

merged 6 commits into from
Apr 9, 2019

Conversation

thebrianchen
Copy link

Reference: b/64156656

@thebrianchen thebrianchen requested a review from mikelehen April 9, 2019 17:37
mikelehen
mikelehen suggested changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This basically looks good but I'm nit-picking the function name and error message. 😄

@mikelehen mikelehen assigned thebrianchen and unassigned mikelehen Apr 9, 2019
thebrianchen
thebrianchen commented Apr 9, 2019
View reviewed changes
Copy link
Author

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review!

@thebrianchen thebrianchen requested a review from mikelehen April 9, 2019 19:47
@thebrianchen thebrianchen assigned mikelehen and unassigned mikelehen Apr 9, 2019
mikelehen
mikelehen suggested changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, two more nits. :-)

@thebrianchen thebrianchen requested a review from mikelehen April 9, 2019 21:34
mikelehen
mikelehen approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks great! Merge at will once travis passes. :-)

@thebrianchen thebrianchen merged commit d4eb7e4 into master Apr 9, 2019
@thebrianchen thebrianchen deleted the chenbrian/enum branch April 9, 2019 22:13
@firebase firebase locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thebrianchen @mikelehen