Skip to content

Update documentation to use yarn build #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 10, 2019
Merged

Conversation

thebrianchen
Copy link

  • Adding yarn build command to main firebase-sdk-js repo
  • Updating firestore documentation

@thebrianchen thebrianchen force-pushed the chenbrian/documentation branch from 088013c to e812d84 Compare April 9, 2019 22:10
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff removed their assignment Apr 10, 2019
@thebrianchen
Copy link
Author

Added more information to the "Automated Setup" section of the main README, and linked to there in the Firestore CONTRIBUTING file.

@thebrianchen thebrianchen requested a review from Feiyang1 April 10, 2019 19:41
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thebrianchen thebrianchen requested a review from Feiyang1 April 10, 2019 20:31
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@thebrianchen thebrianchen merged commit 077b88b into master Apr 10, 2019
@thebrianchen thebrianchen deleted the chenbrian/documentation branch April 10, 2019 21:10
@firebase firebase locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants