Fix test:node:persistence command and make travis run it. #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since our code is TypeScript we use `--require ts-node/register` for mocha to be able to run our code. We have this require in our global `../../config/mocha.node.opts` file, but it apparently isn't applied before the `--require test/util/node_persistence.ts` in our test:node:persistence command-line. So I've had to add an explicit `--require ts-node/register` to our command-line.
schmidt-sebastian
approved these changes
Apr 11, 2019
added 2 commits
April 12, 2019 15:00
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our code is TypeScript we use
--require ts-node/registerfor mocha tobe able to run our code. We have this require in our global
../../config/mocha.node.optsfile, but it apparently isn't applied before the--require test/util/node_persistence.tsin our test:node:persistencecommand-line. So I've had to add an explicit
--require ts-node/registertoour command-line.