Use --concurrency 4 instead of --parallel for tests.
#1693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm hoping this makes travis more reliable by limitting the amount of concurrency for our tests . `--concurrency 4` was also slightly faster than `--parallel` on my local machine. Though any value above 1 was actually fairly comparable: --parallel: 342.63s --concurrency 1: 498.26s --concurrency 2: 351.23s --concurrency 3: 342.50s --concurrency 4: 336.55s --concurrency 5: 349.82s --concurrency 6: 348.19s --concurrency 7: 341.47s --concurrency 8: 348.52s
mikelehen
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
|
Comparing the travis runs to my last PR, it seems like this speeds things up a bit: Before: 679.74s / 678.04s And I notice the RTDB emulator starts muuuch faster: |
|
Wow, that's super good. Thanks so much for doing the experiments. |
Feiyang1
approved these changes
Apr 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping this makes travis more reliable by limiting the amount of concurrency for our tests .
--concurrency 4was also slightly faster than--parallelon my local machine. Though any value above 1 was actually fairly comparable: