Skip to content

Remove extra ! #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2019
Merged

Remove extra ! #1709

merged 1 commit into from
Apr 19, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

thebrianchen
thebrianchen approved these changes Apr 18, 2019
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot less enthusiastic than it once did, but still an LGTM

mikelehen
mikelehen approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @thebrianchen. 😄

@schmidt-sebastian schmidt-sebastian merged commit be5e65f into master Apr 19, 2019
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt-removebang branch April 19, 2019 20:36
@firebase firebase locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @mikelehen @thebrianchen