Skip to content

Track AuthEvent with ID to remove duplicate events #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Conversation

wti806
Copy link
Contributor

@wti806 wti806 commented Apr 23, 2019

Track AuthEvents with event IDs/session IDs in AuthEventManager and ignore duplicate events. This will prevent race conditions when completing sign in with popup.

@wti806 wti806 requested a review from bojeil-google as a code owner April 23, 2019 06:06
@wti806 wti806 merged commit dc70589 into master Apr 23, 2019
@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants