Adding call to clearPersistence() into AsyncQueue

[thebrianchen]

No description provided.

[wilhuff]

You should pull this out of the withTestDoc block so that you can put it in a finally block

const oldDelete = SimpleDb.delete;
try {
  // monkey patch and test
} finally {
  SimpleDb.delete = oldDelete
}

This form is desirable because it prevents a failure in this test from causing unrelated failures in subsequent tests.

[thebrianchen]

The problem with taking the patch out of withTestDoc is that withTestDoc eventually ends up calling withTestDbsSettings, which clears persistence at the end of the the function. Not restoring SimpleDb.delete to its original definition causes those tests to fail when the test is torn down:

 (Persistence=true) Database
    ✗ will reject the promise if clear persistence fails
	Error: the string "Failed to delete the database :(." was thrown, throw an Error :)

HeadlessChrome 74.0.3729 (Mac OS X 10.14.4) (Persistence=true) Database will reject the promise if clear persistence fails FAILED
	Error: the string "Failed to delete the database :(." was thrown, throw an Error :)

What do you think about resetting SimpleDb.delete twice just to be safe?

[wilhuff]

Why not do the try/finally inside withTestDoc then?

[thebrianchen]

Once again, thank you. 🤦

[wilhuff]

LGTM

Thanks for taking the time to make this right!