-
Notifications
You must be signed in to change notification settings - Fork 948
Separate Saucelabs cross-browser tests by package #1756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmermerkaya
approved these changes
May 7, 2019
mmermerkaya
reviewed
May 7, 2019
mmermerkaya
approved these changes
May 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the PR title to a single sentence summary of what you did?
Feiyang1
reviewed
May 9, 2019
|
Feiyang1
approved these changes
May 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up our Saucelabs test to run tests for each package separately and sequentially, making it easier to identify which package/browser combination has failed.
Each run of all tests has one build number and counts as a build in Saucelabs' dashboard. Each test has a separate name based on package name and browser environment. Tests are run on one package at a time, on 5 browsers in parallel.
Will try to address some of the test failures in future PRs.