Standardize shutdown checking logic #1776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
reviewed
May 9, 2019
wilhuff
reviewed
May 9, 2019
| // PORTING NOTE: LocalStore does not need an explicit shutdown on web. | ||
| if (this.lruScheduler) { | ||
| this.lruScheduler.stop(); | ||
| if (this.isShutdown === false) { |
There was a problem hiding this comment.
Is it imperative that this value be strictly checked against false? If not, I'd consider the simpler if (!this.isShutdown).
Looking through our source the convention seems to heavily favor the simpler form:
grep -r 'if (!' packages/firestore/src | wc -l # => 158
grep -r '=== false' packages/firestore/src | wc -l # => 2
If strictness really is required, please comment on why because this seems like something to fix.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.