Skip to content

Remove exception throwing from clearPersistence() #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2019
Merged

Remove exception throwing from clearPersistence() #1793

merged 3 commits into from
May 17, 2019

Conversation

thebrianchen
Copy link

No description provided.

@thebrianchen thebrianchen requested a review from wilhuff May 17, 2019 00:31
wilhuff
wilhuff reviewed May 17, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much LGTM, with some suggestions.

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff May 17, 2019
@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen May 17, 2019
wilhuff
wilhuff approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff May 17, 2019
@thebrianchen thebrianchen merged commit 5f5f1c1 into master May 17, 2019
@thebrianchen thebrianchen deleted the bc/no-throw branch May 17, 2019 21:33
@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thebrianchen @wilhuff