Add performance spec tests for queries against large collections #1802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +66,7 @@ describeSpec( | |||
| fromCache: true, | |||
| hasPendingWrites: true | |||
| }) | |||
| .writeAcks(`collection/${i}`, ++currentVersion) | |||
| .writeAcks(`collection/${i}`, docRemote.version.toMicroseconds()) | |||
| .watchAcksFull(query, ++currentVersion, docRemote) | |||
There was a problem hiding this comment.
Note that in the existing code, this watchAck will get ignored since docRemote.version here is greater than the writeAck version.
mikelehen
approved these changes
May 20, 2019
| @@ -47,7 +49,8 @@ const KNOWN_TAGS = [ | |||
| ]; | |||
|
|
|||
| // TODO(mrschmidt): Make this configurable with mocha options. | |||
| const RUN_BENCHMARK_TESTS = false; | |||
| const RUN_BENCHMARK_TESTS = true; | |||
There was a problem hiding this comment.
Intentionally enabling these? How long do they take?
There was a problem hiding this comment.
Hm. I woke up too early today.
| function getTestRunner( | ||
| tags, | ||
| persistenceEnabled | ||
| ): ExclusiveTestFunction | PendingTestFunction { |
| const mode = usePersistence ? '(Persistence)' : '(Memory)'; | ||
| const fullName = `${mode} ${name}`; | ||
| runner(fullName, async () => { | ||
| const testFunction = runner(fullName, async () => { |
There was a problem hiding this comment.
Thoughts on renaming testFunction to queuedTest or something? I misunderstood what was going on at first.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: