Skip to content

Fix throwing a Promise object instead of Error #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2019
Merged

Fix throwing a Promise object instead of Error #1826

merged 2 commits into from
May 28, 2019

Conversation

mmermerkaya
Copy link
Contributor

getErrorFromResponse returns a Promise that resolves to an Error. I forgot to await the promise before throwing it, resulting in the Promise object being thrown instead of the Error.

@mmermerkaya mmermerkaya merged commit cc4f2b5 into master May 28, 2019
@mmermerkaya mmermerkaya deleted the mmermerkaya-fix-promise-throw branch May 28, 2019 15:43
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwoffinden dwoffinden dwoffinden approved these changes

@andirayo andirayo andirayo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmermerkaya @dwoffinden @andirayo