Enable linting and fix lint issues for app, util and logger #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
hiranya911,
hsubox76,
jsdt,
mikelehen and
schmidt-sebastian
as code owners
hsubox76
reviewed
Jun 5, 2019
packages/util/src/crypt.ts
Outdated
| @@ -154,34 +154,34 @@ export const base64 = { | |||
| * | |||
| * @param input An array of bytes (numbers with | |||
| * value in [0, 255]) to encode. | |||
| * @param opt_webSafe Boolean indicating we should use the | |||
| * @param optwebSafe Boolean indicating we should use the | |||
There was a problem hiding this comment.
Did you mean to get rid of the opt_ entirely? https://engdoc.corp.google.com/eng/doc/devguide/js/styleguide.md?cl=head#features-functions-default-parameters
If not, it should still be camelCase I think.
There was a problem hiding this comment.
Good catch. Updated to webSafe.
There was a problem hiding this comment.
I think they mean option instead of optional to which the google styleguide references, but it is redundant.
hsubox76
approved these changes
Jun 5, 2019
| compress_(buf, opt_offset?) { | ||
| if (!opt_offset) { | ||
| opt_offset = 0; | ||
| compress_(buf, optOffset?): void { |
There was a problem hiding this comment.
Should just be offset if we are following Google style guide (see previous comment)
| @@ -190,53 +190,53 @@ export class Sha1 { | |||
| this.chain_[4] = (this.chain_[4] + e) & 0xffffffff; | |||
| } | |||
|
|
|||
| update(bytes, opt_length?) { | |||
| update(bytes, optLength?): void { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.