Skip to content

Make yarn test:emulator work again #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2019
Merged

Make yarn test:emulator work again #1853

merged 1 commit into from
Jun 7, 2019

Conversation

thebrianchen
Copy link

Without the module set to commonjs, yarn test:emulator fails to import * as tslib_1 from "tslib";.

Other PRs will follow to set up travis testing against emulator.

@thebrianchen thebrianchen requested a review from mikelehen June 7, 2019 00:53
mikelehen
mikelehen approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikelehen mikelehen assigned thebrianchen and unassigned mikelehen Jun 7, 2019
@thebrianchen thebrianchen merged commit 5686479 into master Jun 7, 2019
@thebrianchen thebrianchen deleted the bc/test-emulator-package branch June 7, 2019 01:27
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thebrianchen @mikelehen