Validate performance metrics and attributes before storing them #1917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijianjoy
reviewed
Jun 27, 2019
alikn
approved these changes
Jun 28, 2019
zijianjoy
approved these changes
Jul 16, 2019
Feiyang1
suggested changes
Jul 17, 2019
Feiyang1
approved these changes
Jul 24, 2019
kim-f
force-pushed
the
performance-sdk-validation
branch
from
2df8458 to
0901f8a
Compare
…Firebase Performance error when a specified metric, attribute name, or attribute value fails validation.
…uotes. Code formatter automatically converts strings containing \' to use double quotes.
kim-f
force-pushed
the
performance-sdk-validation
branch
from
0901f8a to
045cbdf
Compare
Henry-W
reviewed
Aug 23, 2019
| }); | ||
|
|
||
| it('returns false when name starts with a reserved prefix', () => { | ||
| expect(isValidCustomMetricName('_invalidMetricName')).to.be.false; |
There was a problem hiding this comment.
@kim-f Hello, I have noticed that i'm getting an uncaught exception for _fp as defined in
can this be updated to ignore the already defined constants?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.