Skip to content

Standardize Firestore transaction errors #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 9, 2019
Merged

Standardize Firestore transaction errors #1937

merged 12 commits into from
Jul 9, 2019

Conversation

thebrianchen
Copy link

  • Standardize errors based on the spreadsheet.
  • Remove local validation for document not found in transactions.

@thebrianchen thebrianchen requested a review from wilhuff July 2, 2019 20:35
wilhuff
wilhuff reviewed Jul 8, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same feedback as the Android PR.

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Jul 8, 2019
@thebrianchen thebrianchen requested a review from wilhuff July 8, 2019 23:00
@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen Jul 8, 2019
wilhuff
wilhuff approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Jul 8, 2019
@thebrianchen thebrianchen merged commit 6a15cd7 into master Jul 9, 2019
@thebrianchen thebrianchen deleted the bc/abort-aborts branch July 9, 2019 00:22
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thebrianchen @wilhuff