Skip to content

Run persistence and node tests in travis #1991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Jul 16, 2019

Currently, node persistence tests aren't being run on CI. This PR adds the node persistence tests to run on CI, but against the emulator as part of the yarn test:travis command.

Edited tests in LRU garbage collector to perform fewer writes, since the tests were timing out on CI.

@thebrianchen thebrianchen changed the title Run persistence and node tests in test:emulator Run persistence and node tests in travis Jul 16, 2019
@thebrianchen thebrianchen force-pushed the bc/emulator-persist branch from b5b1ff3 to fc6eb07 Compare July 16, 2019 21:15
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@mikelehen mikelehen assigned thebrianchen and unassigned mikelehen Jul 16, 2019
@thebrianchen thebrianchen merged commit 62b4680 into master Jul 17, 2019
@thebrianchen thebrianchen deleted the bc/emulator-persist branch July 17, 2019 00:02
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants