Fix Spec tests 'Limbo documents stay consistent' #1994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/specfix
branch
from
ca7c617 to
672723e
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/specfix
branch
from
672723e to
20ff6e3
Compare
|
Assigning this to @mikelehen since he is back and its more of his area of expertise :) You are welcome! |
mikelehen
approved these changes
Jul 17, 2019
| step.clientIndex === undefined || tags.indexOf(MULTI_CLIENT_TAG) !== -1, | ||
| "Cannot use 'client()' to initialize a test that is not tagged with " + | ||
| "'multi-client'. Did you mean to use 'spec()'?" | ||
| ); |
There was a problem hiding this comment.
I wonder if it'd make sense to assert the inverse as well (if this is a multi-client test, then clientIndex must be defined)? Basically:
const isMultiClientTest = tags.indexOf(MULTI_CLIENT_TAG) !== -1;
const hasClientIndex = step.clientIndex !== undefined;
assert(isMultiClientTest === hasClientIndex, "Tests can use client() if-and-only-if they are tagged with 'multi-client'.");
I don't care strongly if that seems pointless though.
There was a problem hiding this comment.
It's not pointless, but not necessarily worth opening an IDE for and fixing since it would not break anything. I'll leave it as an imaginary TODO :)
|
|
||
| const docA = doc('collection/a', 1000, { matches: true }); | ||
| const docADirty = doc( | ||
| 'collection/a', | ||
| 1000, | ||
| { matches: true }, | ||
| { matches: true }, |
There was a problem hiding this comment.
Hrm. Strange that prettier allowed an extra space before...
There was a problem hiding this comment.
It didn't. But the change was never pushed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Limbo documents stay consistent' used the multi-client runner instead of the spec-runner. This PR fixes the test and adds an assert to make sure that this doesn't happen again.