Skip to content

support FIREBASE_DATABASE_EMULATOR_HOST env var #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 22, 2019
Merged

support FIREBASE_DATABASE_EMULATOR_HOST env var #2005

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9c566c3
support FIREBASE_DATABASE_EMULATOR_HOST environment variable
jmwski Jul 17, 2019
c3f3594
[AUTOMATED]: Prettier Code Styling
jmwski Jul 18, 2019
018f443
use one env var definition, remove extra logic
jmwski Jul 19, 2019
bf8dce0
[AUTOMATED]: Prettier Code Styling
jmwski Jul 19, 2019
dfa2921
nit: remove blank line
jmwski Jul 19, 2019
2b399fc
minor version bump and environment variable guard
jmwski Jul 19, 2019
7c5324c
[AUTOMATED]: Prettier Code Styling
jmwski Jul 19, 2019
1a07294
fix unbound variable reference
jmwski Jul 19, 2019
e120f4f
don't export new env variable
jmwski Jul 19, 2019
07efb8e
[AUTOMATED]: Prettier Code Styling
jmwski Jul 19, 2019
cb781c2
revert minor version bump change
jmwski Jul 19, 2019
0dfd256
add cross-referencing comment, prefer env var over app options
jmwski Jul 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/database/src/core/RepoManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ import { RepoInfo } from './RepoInfo';
/** @const {string} */
const DATABASE_URL_OPTION = 'databaseURL';

/**
* This variable is also defined in the firebase node.js admin SDK. Before
* modifying this definition, consult the definition in:
*
* https://github.com/firebase/firebase-admin-node
*
* and make sure the two are consistent.
*/
const FIREBASE_DATABASE_EMULATOR_HOST_VAR = 'FIREBASE_DATABASE_EMULATOR_HOST';

let _staticInstance: RepoManager;

/**
Expand Down Expand Up @@ -80,7 +90,12 @@ export class RepoManager {
* @return {!Database}
*/
databaseFromApp(app: FirebaseApp, url?: string): Database {
const dbUrl: string = url || app.options[DATABASE_URL_OPTION];
let dbEmulatorHost = process.env[FIREBASE_DATABASE_EMULATOR_HOST_VAR];
if (dbEmulatorHost) {
dbEmulatorHost = `http://${dbEmulatorHost}`;
}
const dbUrl: string =
url || dbEmulatorHost || app.options[DATABASE_URL_OPTION];
if (dbUrl === undefined) {
fatal(
"Can't determine Firebase Database URL. Be sure to include " +
Expand Down