Fix a regression that leads to larger bundle size #2006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
requested review from
hiranya911,
hsubox76,
jsdt,
mikelehen and
schmidt-sebastian
as code owners
hsubox76
approved these changes
Jul 18, 2019
packages/util/src/crypt.ts
Outdated
| /** | ||
| * Maps bytes to characters. | ||
| * @type {Object} |
There was a problem hiding this comment.
Probably can re-remove the jsdoc type annotations.
schmidt-sebastian
approved these changes
Jul 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downlevelIterationadds support for iteration protocol for es5 target, but it adds extra codes for simple array iteration.Since it is only required by database, I am only setting it in database's tsconfig.json instead of in the global tsconfig.json to prevent the bloat.
base64was defined as an object literal before. When we enabled typescriptstrictflag, it was changed to a class. Class that are compiled down to es5 can't be treeshaked in rollup, so base64 is included in all packages that depend on@firebase/utilthough they don't use base64. This changes base64 back to object literal with type safety.