Skip to content

Surface transaction errors in browser #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2019
Merged

Surface transaction errors in browser #2017

merged 3 commits into from
Jul 24, 2019

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Jul 24, 2019 •
edited
Loading

Transactions made via http surface all 400 errors as INVALID_ARGUMENT, when they could also be FAILED_PRECONDITION or OUT_OF_RANGE (code).

When possible, parse the error message to determine if the server returned a more specific error code.

@thebrianchen thebrianchen requested a review from mikelehen July 24, 2019 01:44
mikelehen
mikelehen suggested changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This LGTM but I think we can clean up the naming a bit and maybe factor this into a helper.

@mikelehen mikelehen assigned thebrianchen and unassigned mikelehen Jul 24, 2019
@thebrianchen thebrianchen requested a review from mikelehen July 24, 2019 17:18
mikelehen
mikelehen suggested changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little more nitting, sorry.

@mikelehen mikelehen assigned thebrianchen and unassigned mikelehen Jul 24, 2019
@thebrianchen thebrianchen requested a review from mikelehen July 24, 2019 17:43
mikelehen
mikelehen approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it.

@thebrianchen thebrianchen merged commit bccc8a5 into master Jul 24, 2019
@thebrianchen thebrianchen deleted the bc/http-tx branch July 24, 2019 19:06
thebrianchen pushed a commit that referenced this pull request Jul 24, 2019
Surface transaction errors in browser (#2017)
c88b841
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@mikelehen mikelehen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thebrianchen @mikelehen