Skip to content

Clean up unneeded todo #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2019
Merged

Clean up unneeded todo #2019

merged 1 commit into from
Jul 24, 2019

Conversation

thebrianchen
Copy link

No description provided.

@thebrianchen thebrianchen requested a review from wilhuff July 24, 2019 17:25
wilhuff
wilhuff approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Jul 24, 2019
@thebrianchen thebrianchen merged commit 13cdd14 into master Jul 24, 2019
@thebrianchen thebrianchen deleted the bc/string-enum-todo branch July 24, 2019 17:57
thebrianchen pushed a commit that referenced this pull request Jul 24, 2019
todo vanished (#2019)
f28372f
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thebrianchen @wilhuff