Make spec tests easier to debug #2055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this simple change, tests not marked as not "exclusive" will not be translated into JSON. Hence, we can set breakpoints in the spec builder functions. It's really a win win. I also expect this to speed up our spec tests so much that this changes the way we look at unit testing. I am talking microseconds.
mikelehen
approved these changes
Aug 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this simple change, tests missing the "exclusive" tag will not be translated into JSON. Hence, we can set breakpoints in the spec builder functions. It's really a win win.
I also expect this to speed up our spec tests so much that this changes the way we look at unit testing. I am talking microseconds.