Skip to content

make renovate update transitive deps in the lock file #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Aug 6, 2019

No description provided.

@ryanpbrewster
Copy link
Contributor

I'll defer to @mikelehen here, I assume it's fine to update transitive dependencies but lockfiles are only useful if they're stable so I'm not super confident here.

@ryanpbrewster ryanpbrewster removed their assignment Aug 6, 2019
@Feiyang1
Copy link
Member Author

Feiyang1 commented Aug 6, 2019

Updating the transitive deps is no different than updating the direct dependencies IMO, so I don't see more risk doing it.
The lockfile is stable as long as the deps are up to date.

Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"lockFileMaintenance"? What a confusing name... and since it's JSON I guess we can't add a comment to explain it. :-/

Anyway, LGTM. Thanks for tracking this down!

@Feiyang1 Feiyang1 merged commit 862f41a into master Aug 7, 2019
@Feiyang1 Feiyang1 deleted the fei-reno-config branch August 7, 2019 20:46
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants