database sdk not correctly inferring emulator namespace name #2064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmwski
requested review from
jsdt,
mikelehen and
schmidt-sebastian
as code owners
mikelehen
approved these changes
Aug 8, 2019
Yes, I'm not sure how this slipped through. I think I may have been testing this changes concurrently with changes in the Admin SDK when we thought those were going to be necessary. I've tested this manually using only the js sdk. |
mikelehen
pushed a commit
that referenced
this pull request
Aug 12, 2019
* database sdk not correctly inferring emulator namespace name * add environment variable test * [AUTOMATED]: Prettier Code Styling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2016, we added logic for inferring the namespace name to pass to the RTDB emulator from the result of
parseRepoInfo, but we didn't actually create a repo class to communicate with it.