Enable strictNullChecks for scripts/emulator-testing/ #2066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
force-pushed
the
mikelehen/emulator-strict
branch
from
98faaf2 to
ecfff13
Compare
hsubox76
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
Thanks! The stdio change was because a certain amount of output from child processes, including some errors, was getting swallowed unless I specified they should write to process.stdout and process.stderr specifically. I'm still not sure exactly how it works and why inherit wouldn't work for those streams but that seemed to be the combination that was getting results.
|
Interesting... I merged this as-is, but if you remember how to reproduce the issue with child process output getting lost, I can take a peek and reinstate your change if necessary. Else, we can leave this as-is and revisit if it comes up again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the emulator-related part out of https://github.com/firebase/firebase-js-sdk/pull/1941/files and reworked it a bit (trying not to use
!assertions). I'll work on all the Firestore stuff next (sorry for being so slow).NOTE: I left out the
stdio: 'inherit'lines you changed tostdio: ['inherit', process.stdout, process.stderr]as I couldn't figure out what that was for. Let me know if I should pull that in for some reason.