Remove unnecessary tsconfig.json flags. #2067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsconfig.base.json enables "strict" now which implicitly enables "strictFunctionTypes", "strictNullChecks", and "noImplicitAny" so we don't need to do so explicitly. Disabling "alwaysStrict" and "noImplicitThis" was unnecessary since we have no violations.
|
Oops. |
|
LGTM. I wonder if it makes sense to add a different tsconfig setting for our tests, so that we can enable |
schmidt-sebastian
approved these changes
Aug 9, 2019
|
Please ignore comment (just saw https://github.com/firebase/firebase-js-sdk/pull/2068/files) |
mikelehen
pushed a commit
that referenced
this pull request
Aug 12, 2019
tsconfig.base.json enables "strict" now which implicitly enables "strictFunctionTypes", "strictNullChecks", and "noImplicitAny" so we don't need to do so explicitly. Disabling "alwaysStrict" was unnecessary since we have no violations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsconfig.base.json enables "strict" now which implicitly enables
"strictFunctionTypes", "strictNullChecks", and "noImplicitAny" (see https://www.typescriptlang.org/docs/handbook/compiler-options.html) so we don't need
to do so explicitly.
We were disabling "alwaysStrict" but that was unnecessary since we have no violations.