Move isShutdown to state expectations #2102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
approved these changes
Aug 21, 2019
| export async function clearTestPersistence(): Promise<void> { | ||
| await IndexedDbPersistence.clearPersistence(TEST_PERSISTENCE_PREFIX); | ||
| export function clearTestPersistence(): Promise<void> { | ||
| return IndexedDbPersistence.clearPersistence(TEST_PERSISTENCE_PREFIX); |
There was a problem hiding this comment.
I feel like this is a quiz on how async/await works, but I'm stumped... Does your change do anything?
There was a problem hiding this comment.
No... but I find it weird to use async in a method that only uses a single Promise in its return statement. I can turn it into a quiz though!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to move the
isShutdownto the Spec test state expectations. That should help me in my futile attempts to auto-generate spec tests.