rename shutdown to terminate and publish it #2116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
approved these changes
Aug 27, 2019
packages/firebase/index.d.ts
Outdated
| * | ||
| * Termination does not cancel any pending writes and any promises that are awaiting a response | ||
| * from the server will not be resolved. If you have persistence enabled, the next time you | ||
| * start this instance, it will resume attempting to send these writes to the server. |
There was a problem hiding this comment.
s/attempting to send/sending/
egilmorez
reviewed
Aug 27, 2019
packages/firebase/index.d.ts
Outdated
| * After calling `terminate()` only the `clearPersistence()` method may be used. Any other method | ||
| * will throw a `FirestoreError`. | ||
| * | ||
| * To restart after termination, simply create a new instance of FirebaseFirestore with |
There was a problem hiding this comment.
We strenuously avoid using this word (in case there are users who do not find it simple at all). Please remove.
egilmorez
reviewed
Aug 27, 2019
packages/firebase/index.d.ts
Outdated
| * To restart after termination, simply create a new instance of FirebaseFirestore with | ||
| * `firebase.firestore()`. | ||
| * | ||
| * Termination does not cancel any pending writes and any promises that are awaiting a response |
There was a problem hiding this comment.
Suggest a comma after "writes" to disambiguate.
egilmorez
reviewed
Aug 27, 2019
Feiyang1
approved these changes
Aug 27, 2019
wu-hui
changed the base branch from
wuandy/PublicWairForPendingWrites
to
master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.