Skip to content

Upgrade Firestore Emulator to 1.8.2 #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

This should fix the CI failure in #2128

1.5.0 returns the following response to a delete of a non-existing doc:

Firestore (6.4.0) [Connection]: GRPC stream sending: { streamToken: <Buffer 30>,
  writes: 
   [ { delete: 'projects/test-emulator/databases/(default)/documents/test-collection/8ZFesMAbTQGIuVox8P17' } ] }
Firestore (6.4.0) [Connection]: GRPC stream received: { writeResults: 
   [ { transformResults: [], updateTime: { seconds: '0', nanos: 0 } } ],
  streamId: '',
  streamToken: <Buffer 31>,
  commitTime: { seconds: '0', nanos: 0 } }

I believe newer version now return a proper commit and update time.

This should fix the CI failure in #2128
@mikelehen mikelehen merged commit 16253f6 into master Aug 30, 2019
@mikelehen mikelehen deleted the schmidt-sebastian-patch-1-1 branch August 30, 2019 18:53
@mikelehen mikelehen removed their assignment Aug 30, 2019
schmidt-sebastian added a commit that referenced this pull request Sep 4, 2019
This should fix the CI failure in #2128
@firebase firebase locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants