Port matchesAllDocuments() #2166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/indexfree-matches
branch
from
84bc569 to
b4f64f4
Compare
mikelehen
approved these changes
Sep 10, 2019
packages/firestore/src/core/query.ts
Outdated
| this.endAt == null && | ||
| (this.explicitOrderBy.length === 0 || | ||
| (this.explicitOrderBy.length === 1 && | ||
| this.getFirstOrderByField()!.isKeyField())) |
There was a problem hiding this comment.
You could do this.explicitOrderBy[0].field.isKeyField() which would be more congruous with the previous check and avoid the need for !.
There was a problem hiding this comment.
Done. Thanks for the suggestion.
|
Merging this since the pervious CI run passed and changes are just renames/minor. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports:
This will be used to opt out Index-Free query processing for queries that match all documents.