Index-Free: Port LocalStore tests #2173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
force-pushed
the
mrschmidt/missingtests
branch
from
4f73ceb to
944d455
Compare
mikelehen
approved these changes
Sep 12, 2019
| @@ -324,9 +348,9 @@ export function docAddedRemoteEvent( | |||
| doc | |||
| ); | |||
| aggregator.handleDocumentChange(docChange); | |||
| version = doc.version.compareTo(version) ? doc.version : version; | |||
There was a problem hiding this comment.
What does this do? It seems like doc.version.compareTo(version) will be falsey iff the versions are equal and so this is equivalent to version = doc.version. Or maybe you meant to implement something else?
There was a problem hiding this comment.
Let's see:
version = doc.version.compareTo(version) ? doc.version : version;
=>
version = doc.version != version ? doc.version : doc.version;
=>
version = doc.version
So you are right. It's a fancy way of picking the last version.
I rewrote it to pick the highest version instead.
| * @param expectedCount.documentsByQuery The number of mutations read by | ||
| * executing a query against the RemoteDocumentCache. | ||
| * @param expectedCount.documentsByKey The number of documents read by | ||
| * single-key lookups. |
There was a problem hiding this comment.
FWIW single-key is a bit misleading here and above since the count includes multi-key lookups as well (IFIUC).
There was a problem hiding this comment.
Changed to "document key lookups".
schmidt-sebastian
force-pushed
the
mrschmidt/engine
branch
from
bec52ae to
fdff9cd
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/engine
branch
from
6fc8eba to
1aa22ac
Compare
schmidt-sebastian
changed the base branch from
mrschmidt/engine
to
mrschmidt/indexfree-master
…base-js-sdk into mrschmidt/indexfree-master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the new LocalStore tests for Index-Free starting from https://github.com/firebase/firebase-android-sdk/blob/master/firebase-firestore/src/test/java/com/google/firebase/firestore/local/LocalStoreTestCase.java#L1035
During the porting, I realized that the new number of documents counter doesn't quite work (as predicted by @mikelehen). I had to modify it to differentiate between documents returned during query execution and documents read by single-key lookup.
I also added a second commit that uses it.skip instead of exiting out of tests early when
gcIsEageris not set correctly. This ports some of the changes made to the Android LocalStore tests, but I just realized that there are still some test that exit early on Android. With that said, I don't feel very strongly about 944d445.