Add Query to Target ID Map #2179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…base-js-sdk into mrschmidt/indexfree-master
…base-js-sdk into mrschmidt/indexfree-master
| return PersistencePromise.resolve(); | ||
| } | ||
| }); | ||
| const targetId = this.targetIdByQuery.get(query); |
There was a problem hiding this comment.
We now have a map to look up targetIds for active queries, so we no longer need to go to the QueryCache.
schmidt-sebastian
force-pushed
the
mrschmidt/lookup
branch
from
cd2a0e2 to
5765d98
Compare
mikelehen
approved these changes
Sep 17, 2019
| return PersistencePromise.resolve(); | ||
| } | ||
| }); | ||
| const targetId = this.targetIdByQuery.get(query); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the O(n) loop in getQueryData() with a key lookup in an ObjectMap. This follows the precedent in SyncEngine (and maybe eventually leads us down the path of merging the different query tracking mechanisms).