Skip to content

Sort classes properly in doc. #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Sort classes properly in doc. #2182

merged 1 commit into from
Oct 1, 2019

Conversation

gabrc
Copy link
Contributor

@gabrc gabrc commented Sep 19, 2019

Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks Gabriel!

We should make it our policy to keep alphabetical order within PAs going forward.

@hsubox76
Copy link
Contributor

Thanks!

  1. I'm adding Eric Gilmore from docs, if he approves we can merge.
  2. Don't forget to also change the Node TOC file as well (it is identical minus auth methods that are not supported in Node)

@gabrc
Copy link
Contributor Author

gabrc commented Sep 24, 2019

Thank you. I've updated the other file.

Sorry for the force push. I'm new to Git, and was told I shouldn't have done that.

@hsubox76 hsubox76 merged commit d63371f into master Oct 1, 2019
@firebase firebase locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants